-
Couldn't load subscription status.
- Fork 23
Improve docs, small refactor of reconstruction measures #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docs, small refactor of reconstruction measures #275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the cleanup!
Can you maybe highlight the None as with backticks? I found a couple but probably I missed some.
Also, we could check removing the default from the docstring, if the rendering is good enough.
Co-authored-by: Philip Loche <[email protected]>
Co-authored-by: Philip Loche <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful. Just a small test and we can merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks @sofiia-chorna for your first commit to scikit-matter 🚀
Contributor (creator of PR) checklist
For Reviewer
📚 Documentation preview 📚: https://scikit-matter--275.org.readthedocs.build/en/275/